From 1b82efe5d21eca044efe749ca3094b21d170bf84 Mon Sep 17 00:00:00 2001
From: Sag <guptazy@gmail.com>
Date: Tue, 24 Oct 2023 11:00:11 -0300
Subject: [PATCH] =?UTF-8?q?=E2=9C=A8=20Added=20Recommendations=20feature?=
 =?UTF-8?q?=20(#18743)?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

refs https://github.com/TryGhost/Product/issues/3744


Co-authored-by: Simon Backx <simon@ghost.org>
Co-authored-by: Djordje Vlaisavljevic <dzvlais@gmail.com>
---
 .../settings/advanced/labs/AlphaFeatures.tsx       |  4 ----
 apps/admin-x-settings/test/utils/acceptance.ts     |  1 -
 ghost/admin/app/templates/settings/labs.hbs        | 14 --------------
 ghost/core/core/shared/labs.js                     |  4 ++--
 .../admin/__snapshots__/settings.test.js.snap      |  2 +-
 5 files changed, 3 insertions(+), 22 deletions(-)

diff --git a/apps/admin-x-settings/src/components/settings/advanced/labs/AlphaFeatures.tsx b/apps/admin-x-settings/src/components/settings/advanced/labs/AlphaFeatures.tsx
index 9cf2300390..9ee19d4217 100644
--- a/apps/admin-x-settings/src/components/settings/advanced/labs/AlphaFeatures.tsx
+++ b/apps/admin-x-settings/src/components/settings/advanced/labs/AlphaFeatures.tsx
@@ -47,10 +47,6 @@ const features = [{
     title: 'Tips & donations',
     description: 'Enables publishers to collect one-time payments',
     flag: 'tipsAndDonations'
-},{
-    title: 'Recommendations',
-    description: 'Enables publishers to recommend sites to their audience',
-    flag: 'recommendations'
 },{
     title: 'List-Unsubscribe header',
     description: 'Set the List-Unsubscribe header in emails',
diff --git a/apps/admin-x-settings/test/utils/acceptance.ts b/apps/admin-x-settings/test/utils/acceptance.ts
index 511741d457..c19bb784c7 100644
--- a/apps/admin-x-settings/test/utils/acceptance.ts
+++ b/apps/admin-x-settings/test/utils/acceptance.ts
@@ -51,7 +51,6 @@ export const responseFixtures = {
 };
 
 let defaultLabFlags = {
-    recommendations: false,
     audienceFeedback: false,
     collections: false,
     themeErrorsNotification: false,
diff --git a/ghost/admin/app/templates/settings/labs.hbs b/ghost/admin/app/templates/settings/labs.hbs
index ae43c6a89b..46dbf086fc 100644
--- a/ghost/admin/app/templates/settings/labs.hbs
+++ b/ghost/admin/app/templates/settings/labs.hbs
@@ -351,20 +351,6 @@
                         </div>
                     </div>
                 </div>
-
-                <div class="gh-expandable-block">
-                    <div class="gh-expandable-header">
-                        <div>
-                            <h4 class="gh-expandable-title">Recommendations</h4>
-                            <p class="gh-expandable-description">
-                                Enables publishers to recommend sites to their audience
-                            </p>
-                        </div>
-                        <div class="for-switch">
-                            <GhFeatureFlag @flag="recommendations" />
-                        </div>
-                    </div>
-                </div>
             </div>
         </div>
         {{/if}}
diff --git a/ghost/core/core/shared/labs.js b/ghost/core/core/shared/labs.js
index e849c71873..a1b0e2e173 100644
--- a/ghost/core/core/shared/labs.js
+++ b/ghost/core/core/shared/labs.js
@@ -19,7 +19,8 @@ const GA_FEATURES = [
     'themeErrorsNotification',
     'outboundLinkTagging',
     'announcementBar',
-    'signupForm'
+    'signupForm',
+    'recommendations'
 ];
 
 // NOTE: this allowlist is meant to be used to filter out any unexpected
@@ -40,7 +41,6 @@ const ALPHA_FEATURES = [
     'collectionsCard',
     'tipsAndDonations',
     'importMemberTier',
-    'recommendations',
     'lexicalIndicators',
     'listUnsubscribeHeader',
     'editorEmojiPicker'
diff --git a/ghost/core/test/e2e-api/admin/__snapshots__/settings.test.js.snap b/ghost/core/test/e2e-api/admin/__snapshots__/settings.test.js.snap
index f845a9ce4b..2f7c7edf53 100644
--- a/ghost/core/test/e2e-api/admin/__snapshots__/settings.test.js.snap
+++ b/ghost/core/test/e2e-api/admin/__snapshots__/settings.test.js.snap
@@ -758,7 +758,7 @@ exports[`Settings API Edit Can edit a setting 2: [headers] 1`] = `
 Object {
   "access-control-allow-origin": "http://127.0.0.1:2369",
   "cache-control": "no-cache, private, no-store, must-revalidate, max-stale=0, post-check=0, pre-check=0",
-  "content-length": "4255",
+  "content-length": "4280",
   "content-type": "application/json; charset=utf-8",
   "content-version": StringMatching /v\\\\d\\+\\\\\\.\\\\d\\+/,
   "etag": StringMatching /\\(\\?:W\\\\/\\)\\?"\\(\\?:\\[ !#-\\\\x7E\\\\x80-\\\\xFF\\]\\*\\|\\\\r\\\\n\\[\\\\t \\]\\|\\\\\\\\\\.\\)\\*"/,