From 057d952e27f01bfab7cde33377f22f27c146d22e Mon Sep 17 00:00:00 2001 From: Djordje Vlaisavljevic Date: Wed, 8 Nov 2023 16:44:48 +0000 Subject: [PATCH] Made new recommendation email more flexible (#18915) refs https://github.com/TryGhost/Product/issues/4095 - Removes `min-height` of the card in order to make the template more flexible half-empty states look better (missing description, short description, featured image...) - Fixes wrong variables used in Outlook-specific template --- .../recommendation-emails.test.js.snap | 57 ++++++++++++------- .../lib/email-templates/partials/styles.hbs | 7 +++ .../recommendation-received.hbs | 30 ++++++---- 3 files changed, 61 insertions(+), 33 deletions(-) diff --git a/ghost/core/test/e2e-server/services/__snapshots__/recommendation-emails.test.js.snap b/ghost/core/test/e2e-server/services/__snapshots__/recommendation-emails.test.js.snap index c1ac41b64f..d603e456bc 100644 --- a/ghost/core/test/e2e-server/services/__snapshots__/recommendation-emails.test.js.snap +++ b/ghost/core/test/e2e-server/services/__snapshots__/recommendation-emails.test.js.snap @@ -108,6 +108,13 @@ exports[`Incoming Recommendation Emails Sends a different email if we receive a padding-left: 20px; border-left: 3px solid #DDE1E5; } + .recommendation-card--outlook { + margin: 0; + padding: 0; + width: 100%; + border: 1px solid #F9F9FA; + background: #F9F9FA; + } @@ -132,35 +139,33 @@ exports[`Incoming Recommendation Emails Sends a different email if we receive a

A site you’re recommending is now recommending you back:

-
- +
+
Other Ghost Site
-
-
- +
+
Other Ghost Site
-
-
- +
+
Other Ghost Site
-
-
- +
+
{{#if recommendation.favicon}}{{/if}}
{{recommendation.title}}
-
{{recommendation.excerpt}}
+ {{#if recommendation.excerpt}} +
{{recommendation.excerpt}}
+ {{/if}}
{{#if recommendation.featuredImage}}
@@ -52,26 +54,30 @@