OpenSourceArk/Ghost
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
f37d7a3fc7
Ghost/ghost/admin/app/components/modals/confirm-unsaved-changes.hbs

19 lines
836 B
Handlebars
Raw Normal View History

🐛 Fixed close button on "unsaved changes" modal not always behaving like "Stay" button no issue The close button in the unsaved changes modal used the `@close` action directly compared to the "Stay" button which used `(fn @close false)`. The close button version without explicit arguments resulted in the first argument being a `PointerEvent` instance which if checked as a modal return value as `if (shouldClose)` would evaluate as truthy therefore matching the "Leave" behaviour instead of the "Stay" behaviour. - changed modal to explicitly call `(fn @close false)` when the close button is clicked - updated design settings route to have an explicit `shouldLeave === true` check so default behaviour is always "Stay"
2022-04-14 14:39:10 +03:00
<div class="modal-content" data-test-modal="unsaved-settings">
<header class="modal-header">
Fixed customize design route-based modal handling + added unsaved change confirmation refs https://github.com/TryGhost/Team/issues/559 refs https://github.com/TryGhost/Team/issues/1045 - removed need for `{{will-destroy}}` in the modal template by using `willTransition()` in the route that opened the modal instead - used the property of new modals acting as promises to implement an unsaved changes confirmation modal - added `confirmUnsavedChanges()` method that opens a "are you sure you want to leave?" modal that is treated as a promise. If the modal is closed by the "Leave" button the promise returns true in which case we rollback the unsaved changes. The modal is returned so that other behaviour can use this method and wait for the confirmation result - added `willTransition()` route hook that calls `confirmUnsavedChanges()` when there are unsaved changes and will only continue to transition if the "Leave" button is pressed - added `beforeClose()` hook to the customize modal when opening so that we can prevent the customize modal from closing when "Stay" is clicked in the confirmation modal - updated `activate()` hook to store the modal instance so it can be closed later - updated `deactivate()` hook to call `.close()` on the modal instance rather than using private data/methods on the modals service
2021-09-16 22:26:49 +03:00
<h1>Are you sure you want to leave this page?</h1>
</header>
Update dependency ember-template-lint to v5.3.0 (#16062) refs https://github.com/TryGhost/Ghost/pull/15550 Pulled out of the rolled up node+ember-js+ember-template rollup linter update PR as it required fairly extensive changes. - bumped package - renamed `no-down-event-binding` to `no-pointer-down-event-binding` - disabled `no-pointer-down-event-binding` rule - disabled `no-triple-curlies` rule - ran `yarn lint:hbs --fix` - updated integration tests to match Octane syntax - fixed various one-off errors - updated .lint-todo
2023-01-04 12:39:32 +03:00
<button type="button" class="close" title="Close" {{on "click" (fn @close false)}} data-test-button="close">{{svg-jar "close"}}<span class="hidden">Close</span></button>
Fixed customize design route-based modal handling + added unsaved change confirmation refs https://github.com/TryGhost/Team/issues/559 refs https://github.com/TryGhost/Team/issues/1045 - removed need for `{{will-destroy}}` in the modal template by using `willTransition()` in the route that opened the modal instead - used the property of new modals acting as promises to implement an unsaved changes confirmation modal - added `confirmUnsavedChanges()` method that opens a "are you sure you want to leave?" modal that is treated as a promise. If the modal is closed by the "Leave" button the promise returns true in which case we rollback the unsaved changes. The modal is returned so that other behaviour can use this method and wait for the confirmation result - added `willTransition()` route hook that calls `confirmUnsavedChanges()` when there are unsaved changes and will only continue to transition if the "Leave" button is pressed - added `beforeClose()` hook to the customize modal when opening so that we can prevent the customize modal from closing when "Stay" is clicked in the confirmation modal - updated `activate()` hook to store the modal instance so it can be closed later - updated `deactivate()` hook to call `.close()` on the modal instance rather than using private data/methods on the modals service
2021-09-16 22:26:49 +03:00
<div class="modal-body">
<p>
Hey there! It looks like you didn't save the changes you made.
</p>
<p>Save before you go!</p>
</div>
<div class="modal-footer">
[chore] adds ember-template-lint and fixes all fixable issues (#2238) no issue - This will help with the octane migration and you can still run the lint rules even when they are todos. (Checkout the docs at https://github.com/ember-template-lint/ember-template-lint/blob/158b1196676489b4bfc01f851b46d3aecd2b314e/docs/todos.md) The good news is any new code will be checked against the recommended config. - I fixed all the auto fixable things we could get in this PR as well
2022-02-02 19:09:43 +03:00
<button class="gh-btn" data-test-stay-button type="button" {{on "click" (fn @close false)}}><span>Stay</span></button>
<button class="gh-btn gh-btn-red" data-test-leave-button type="button" {{on "click" (fn @close true)}}><span>Leave</span></button>
Fixed customize design route-based modal handling + added unsaved change confirmation refs https://github.com/TryGhost/Team/issues/559 refs https://github.com/TryGhost/Team/issues/1045 - removed need for `{{will-destroy}}` in the modal template by using `willTransition()` in the route that opened the modal instead - used the property of new modals acting as promises to implement an unsaved changes confirmation modal - added `confirmUnsavedChanges()` method that opens a "are you sure you want to leave?" modal that is treated as a promise. If the modal is closed by the "Leave" button the promise returns true in which case we rollback the unsaved changes. The modal is returned so that other behaviour can use this method and wait for the confirmation result - added `willTransition()` route hook that calls `confirmUnsavedChanges()` when there are unsaved changes and will only continue to transition if the "Leave" button is pressed - added `beforeClose()` hook to the customize modal when opening so that we can prevent the customize modal from closing when "Stay" is clicked in the confirmation modal - updated `activate()` hook to store the modal instance so it can be closed later - updated `deactivate()` hook to call `.close()` on the modal instance rather than using private data/methods on the modals service
2021-09-16 22:26:49 +03:00
</div>
</div>
Reference in New Issue Copy Permalink