From f10ecc91e0f613c8a4dd83dde57819f8d4919a68 Mon Sep 17 00:00:00 2001 From: James Norman Date: Thu, 17 Dec 2015 11:14:38 +0000 Subject: [PATCH 1/2] Adds support for specifying admin users --- samba.sh | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/samba.sh b/samba.sh index 9848176..8821faa 100755 --- a/samba.sh +++ b/samba.sh @@ -39,7 +39,7 @@ import() { local name id file="${1}" # users) list of allowed users # Return: result share() { local share="$1" path="$2" browse=${3:-yes} ro=${4:-yes}\ - guest=${5:-yes} users=${6:-""} file=/etc/samba/smb.conf + guest=${5:-yes} users=${6:-""} admins=${7:-"none"} file=/etc/samba/smb.conf sed -i "/\\[$share\\]/,/^\$/d" $file echo "[$share]" >>$file echo " path = $path" >>$file @@ -48,6 +48,8 @@ share() { local share="$1" path="$2" browse=${3:-yes} ro=${4:-yes}\ echo " guest ok = $guest" >>$file [[ ${users:-""} && ! ${users:-""} =~ all ]] && echo " valid users = $(tr ',' ' ' <<< $users)" >>$file + [[ ${admins:-""} && ! ${admins:-""} =~ none ]] && + echo " admin users = $(tr ',' ' ' <<< $admins)" >>$file echo -e "" >>$file } @@ -97,6 +99,7 @@ Options (fields in '[]' are optional, '<>' are required): [readonly] default:'yes' or 'no' [guest] allowed default:'yes' or 'no' [users] allowed default:'all' or list of allowed users + [admins] allowed default:'none' or list of admin users -t \"\" Configure timezone possible arg: \"[timezone]\" - zoneinfo timezone for container -u \"\" Add a user From 2bc21806aeb0ed2b3cae0cf2007a4a8b2b643f30 Mon Sep 17 00:00:00 2001 From: James Norman Date: Thu, 17 Dec 2015 11:17:34 +0000 Subject: [PATCH 2/2] Updates docs --- README.md | 1 + samba.sh | 1 + 2 files changed, 2 insertions(+) diff --git a/README.md b/README.md index a356aeb..56f7c00 100644 --- a/README.md +++ b/README.md @@ -41,6 +41,7 @@ OR set local storage: [readonly] default:'yes' or 'no' [guest] allowed default:'yes' or 'no' [users] allowed default:'all' or list of allowed users + [admins] allowed default:'none' or list of admin users -t "" Configure timezone possible arg: "[timezone]" - zoneinfo timezone for container -u "" Add a user diff --git a/samba.sh b/samba.sh index 8821faa..2188c4b 100755 --- a/samba.sh +++ b/samba.sh @@ -37,6 +37,7 @@ import() { local name id file="${1}" # readonly) 'yes' or 'no' # guest) 'yes' or 'no' # users) list of allowed users +# admins) list of admin users # Return: result share() { local share="$1" path="$2" browse=${3:-yes} ro=${4:-yes}\ guest=${5:-yes} users=${6:-""} admins=${7:-"none"} file=/etc/samba/smb.conf