From d7d5d8253cb403d32fc8486473f4c2d0c9ca0639 Mon Sep 17 00:00:00 2001
From: Jacky Zhao <j.zhao2k19@gmail.com>
Date: Wed, 17 Jan 2024 09:45:05 -0800
Subject: [PATCH] fix: clean up ofm code for video parsing

---
 quartz/plugins/transformers/ofm.ts | 22 ++++++++++------------
 1 file changed, 10 insertions(+), 12 deletions(-)

diff --git a/quartz/plugins/transformers/ofm.ts b/quartz/plugins/transformers/ofm.ts
index 8caad979e..76234dde1 100644
--- a/quartz/plugins/transformers/ofm.ts
+++ b/quartz/plugins/transformers/ofm.ts
@@ -1,10 +1,10 @@
 import { QuartzTransformerPlugin } from "../types"
-import { Root, Html, BlockContent, DefinitionContent, Paragraph, Code } from "mdast"
+import { Root, Html, Image, BlockContent, DefinitionContent, Paragraph, Code } from "mdast"
 import { Element, Literal, Root as HtmlRoot } from "hast"
 import { ReplaceFunction, findAndReplace as mdastFindReplace } from "mdast-util-find-and-replace"
 import { slug as slugAnchor } from "github-slugger"
 import rehypeRaw from "rehype-raw"
-import { visit } from "unist-util-visit"
+import { SKIP, visit } from "unist-util-visit"
 import path from "path"
 import { JSResource } from "../../util/resources"
 // @ts-ignore
@@ -39,7 +39,7 @@ const defaultOptions: Options = {
   parseBlockReferences: true,
   enableInHtmlEmbed: false,
   enableYouTubeEmbed: true,
-  enableVideoEmbed: false,
+  enableVideoEmbed: true,
 }
 
 const icons = {
@@ -357,17 +357,15 @@ export const ObsidianFlavoredMarkdown: QuartzTransformerPlugin<Partial<Options>
         plugins.push(() => {
           return (tree: Root, _file) => {
             visit(tree, "image", (node, index, parent) => {
-              const match = node.url.match(videoExtensionRegex)
-              if (parent && match) {
-                const htmlNode: PhrasingContent = {
+              if (parent && index != undefined && videoExtensionRegex.test(node.url)) {
+                console.log("replacin")
+                const newNode: Html = {
                   type: "html",
-                  value: `<video controls src="${node.url}" controls></video>`,
-                }
-                if (index && index >= 0 && index < parent.children.length) {
-                  parent.children.splice(index, 1, htmlNode)
-                } else {
-                  console.warn("Warning: Invalid index, htmlNode not added")
+                  value: `<video controls src="${node.url}"></video>`,
                 }
+
+                parent.children.splice(index, 1, newNode)
+                return SKIP
               }
             })
           }