From 66d7dd8677e5ef05c97773f3590d43ef97d21d98 Mon Sep 17 00:00:00 2001
From: Aaron Pham <contact@aarnphm.xyz>
Date: Sun, 6 Oct 2024 22:34:31 -0400
Subject: [PATCH] fix(ci): run build on tags (#1483)

* fix(ci): run build on tags

Signed-off-by: Aaron Pham <contact@aarnphm.xyz>

* chore: update docker warning and not push on PR

Signed-off-by: Aaron Pham <contact@aarnphm.xyz>

---------

Signed-off-by: Aaron Pham <contact@aarnphm.xyz>
---
 .github/workflows/docker-build-push.yaml | 4 ++--
 Dockerfile                               | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/.github/workflows/docker-build-push.yaml b/.github/workflows/docker-build-push.yaml
index e72c96700..61ec110e6 100644
--- a/.github/workflows/docker-build-push.yaml
+++ b/.github/workflows/docker-build-push.yaml
@@ -3,7 +3,7 @@ name: Docker build & push image
 on:
   push:
     branches: [v4]
-  tags: ["v*"]
+    tags: ["v*"]
   pull_request:
     branches: [v4]
     paths:
@@ -78,7 +78,7 @@ jobs:
         id: build-and-push
         uses: docker/build-push-action@v6
         with:
-          push: true
+          push: ${{ github.event_name != 'pull_request' }}
           build-args: |
             GIT_SHA=${{ env.GITHUB_SHA }}
             DOCKER_LABEL=sha-${{ env.GITHUB_SHA_SHORT }}
diff --git a/Dockerfile b/Dockerfile
index 1d9e5915f..4493853e2 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -1,4 +1,4 @@
-FROM node:20-slim as builder
+FROM node:20-slim AS builder
 WORKDIR /usr/src/app
 COPY package.json .
 COPY package-lock.json* .