diff --git a/content/features/upcoming features.md b/content/features/upcoming features.md index 2045be7bf..7093a5bf9 100644 --- a/content/features/upcoming features.md +++ b/content/features/upcoming features.md @@ -4,9 +4,6 @@ draft: true ## todo -- static icon path (in head) never gets updated - - do we update relative links on spa? -- back button with anchors / popovers + spa is broken - debounce cfg rebuild on large repos - investigate content rebuild triggering multiple times even when debounced, causing an esbuild deadlock - dereference symlink for npx quartz sync diff --git a/quartz/components/scripts/graph.inline.ts b/quartz/components/scripts/graph.inline.ts index 0a7c19ee4..bea32eb3f 100644 --- a/quartz/components/scripts/graph.inline.ts +++ b/quartz/components/scripts/graph.inline.ts @@ -179,7 +179,6 @@ async function renderGraph(container: string, slug: CanonicalSlug) { const neighbourNodes = d3 .selectAll(".node") .filter((d) => neighbours.includes(d.id)) - console.log(neighbourNodes) const currentId = d.id const linkNodes = d3 .selectAll(".link") diff --git a/quartz/components/scripts/search.inline.ts b/quartz/components/scripts/search.inline.ts index 5c7dae012..b94cdfbc3 100644 --- a/quartz/components/scripts/search.inline.ts +++ b/quartz/components/scripts/search.inline.ts @@ -148,7 +148,6 @@ document.addEventListener("nav", async (e: unknown) => { async function onType(e: HTMLElementEventMap["input"]) { const term = (e.target as HTMLInputElement).value const searchResults = (await index?.searchAsync(term, numSearchResults)) ?? [] - console.log(searchResults) const getByField = (field: string): number[] => { const results = searchResults.filter((x) => x.field === field) return results.length === 0 ? [] : ([...results[0].result] as number[]) diff --git a/quartz/components/scripts/spa.inline.ts b/quartz/components/scripts/spa.inline.ts index 1b44ade0d..e0a837311 100644 --- a/quartz/components/scripts/spa.inline.ts +++ b/quartz/components/scripts/spa.inline.ts @@ -46,10 +46,6 @@ async function navigate(url: URL, isBack: boolean = false) { }) if (!contents) return - if (!isBack) { - history.pushState({}, "", url) - window.scrollTo({ top: 0 }) - } const html = p.parseFromString(contents, "text/html") let title = html.querySelector("title")?.textContent @@ -65,8 +61,20 @@ async function navigate(url: URL, isBack: boolean = false) { announcer.dataset.persist = "" html.body.appendChild(announcer) + // morph body micromorph(document.body, html.body) + // scroll into place and add history + if (!isBack) { + history.pushState({}, "", url) + if (url.hash) { + const el = document.getElementById(url.hash.substring(1)) + el?.scrollIntoView() + } else { + window.scrollTo({ top: 0 }) + } + } + // now, patch head const elementsToRemove = document.head.querySelectorAll(":not([spa-preserve])") elementsToRemove.forEach((el) => el.remove()) @@ -92,8 +100,9 @@ function createRouter() { } }) - window.addEventListener("popstate", () => { - if (window.location.hash) return + window.addEventListener("popstate", (event) => { + const { url } = getOpts(event) ?? {} + if (window.location.hash && window.location.pathname === url?.pathname) return try { navigate(new URL(window.location.toString()), true) } catch (e) {